Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible wrong autocorrection in namespace on Style/PerlBackrefs #10975

Merged
merged 1 commit into from Aug 29, 2022

Conversation

r7kamura
Copy link
Contributor

Inserting constants in the code without :: prefix may cause problems in situations where Module.nesting is not empty, as the test case I added describes.

In order to eliminate the possibility of such unsafe autocorrection, it would be better to prepend ::, even if it looks a bit verbose.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit aac9358 into rubocop:master Aug 29, 2022
@bbatsov
Copy link
Collaborator

bbatsov commented Aug 29, 2022

Fine by me. Thanks!

@r7kamura r7kamura deleted the feature/perl branch August 29, 2022 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants